-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): disable scheduledPublishing and tasks if /features
returns error
#7517
Open
pedrobonamin
wants to merge
2
commits into
next
Choose a base branch
from
edx-1599
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…api returns error
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
pedrobonamin
requested review from
a team and
rexxars
and removed request for
a team
September 17, 2024 12:11
pedrobonamin
changed the title
fix(core): disable scheduledPublishing and tasks plugins if features returns error
fix(core): disable scheduledPublishing and tasks plugins if Sep 17, 2024
/features
returns error
pedrobonamin
changed the title
fix(core): disable scheduledPublishing and tasks plugins if
fix(core): disable scheduledPublishing and tasks if Sep 17, 2024
/features
returns error/features
returns error
No changes to documentation |
Component Testing Report Updated Sep 17, 2024 3:36 PM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
commented
Sep 17, 2024
<Container width={1} paddingTop={4}> | ||
<Box paddingTop={4} paddingX={4}> | ||
<ErrorCallout | ||
description="You do not have permission to edit schedules." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some users have reported that they see the upsell ui even though the feature is enabled for the project.
That is due to the
features
api returning an error if the user doesn't have the right permissions to query it.This PR adds the same check for
scheduledPublishing
andtasks
plugins.In
comments
we are currently doing that check here https://github.com/sanity-io/sanity/blob/edx-1599/packages/sanity/src/core/comments/hooks/useResolveCommentsEnabled.ts#L42-L43What to review
Are this changes ok?
Testing
New tests have been introduced to guard this behavior.
Notes for release
Disable schedule publishing and tasks plugin if user doesn't have the right access.